Added integration test for overall stats CSV generation#1060
Open
N00ria wants to merge 1 commit intomapswipe:devfrom
Open
Added integration test for overall stats CSV generation#1060N00ria wants to merge 1 commit intomapswipe:devfrom
N00ria wants to merge 1 commit intomapswipe:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I added a integration test for get_overall_stats().
It checks that the function writes a valid CSV, the columns exist, and the aggregated values match expected results.
While running this, I also noticed a pandas FutureWarning related to .fillna(inplace=True) inside overall_stats.py. The test still passes fine, but just wanted to bring it to your attention in case the team wants to update this later.
Please let me know if anything should be adjusted!